Add upload and verification to the fast pusher #2128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
8W9aG
commented
Jan 27, 2025
- Creates an S3 client for uploading based on the response from the upload service
- Begins a verification step after the upload is completed
- Check the verification state in a loop
* Creates an S3 client for uploading based on the response from the upload service * Begins a verification step after the upload is completed * Check the verification state in a loop
meatballhat
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
With the understanding that uploadFile will need to grow a ctx context.Context first arg in the signature and the use of the managed uploader is almost certainly going to be needed.
🎉
meatballhat
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.