[Core] New LazyConnection with background auto-reconnect #3215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 1, 2025
6aafcc4 to
1dca721
Compare
2870202 to
2a5c795
Compare
tillrohrmann
approved these changes
May 2, 2025
Comment on lines
384
to
391
| Err( | ||
| // We don't know this node-id yet, but we might in the future, keep retrying. | ||
| err @ ConnectError::Discovery(DiscoveryError::UnknownNodeId(_)), | ||
| ) => { | ||
| trace!(%swimlane, %peer, "Cannot to connect, will retry: {}", err); | ||
| continue 'connect; |
There was a problem hiding this comment.
Could this be a busy loop?
There was a problem hiding this comment.
Yes, good catch. I'll add a hardcoded 500ms sleep here.
Other changes: - Smaller EgressMessages by using static string for message names, removing span for unary messages (224 bytes -> 216 bytes) - ReplyRx doesn't require protocol version at creation time, this will become relevant in a subsequent PR. The protocol version is now returned along with the reply when it arrives
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack created with Sapling. Best reviewed with ReviewStack.