introduce BilrostAs derive macro #3208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f7ce1d to
2117901
Compare
|
@AhmedSoliman I recommend that you look at the tests here https://github.com/restatedev/restate/pull/3208/files#diff-84254cab3a4d09daad7bfb0f2f851bec0b3151449b5a620fb49df41878ed216f first to see how the macro is used |
|
|
||
| Err(syn::Error::new( | ||
| input.span(), | ||
| "Missing bilrost_as attribute", |
There was a problem hiding this comment.
Worth including usage example to help the user.
1566839 to
739bcf0
Compare
|
The |
AhmedSoliman
approved these changes
May 2, 2025
| @@ -90,6 +94,9 @@ where | |||
| } | |||
|
|
|||
| impl<V> NetSerde for HashSet<V> where V: NetSerde {} | |||
| impl<Idx> NetSerde for RangeInclusive<Idx> where Idx: NetSerde {} | |||
| impl<T> NetSerde for Arc<T> where T: NetSerde {} | |||
| impl<T> NetSerde for Arc<[T]> where T: NetSerde {} | |||
There was a problem hiding this comment.
nit: can we also have Box<[T]>?
Summary: The macro can be deriven on anytime given that the target type can be created From<&T>. There is also an implementation for an adaptor that can use the `Display` and `FromStr` to serialize and deserialize the type. ## Notice: Right now the BilrostAs macro requires that the annotated type must implement `Default`. This is needed since Bilrost requires that it can create an `empty state` of that field.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduce BilrostAs derive macro
Summary:
The macro can be deriven on anytime given that the target type
can be created From<&T>.
There is also an implementation for an adaptor that can use the
DisplayandFromStrto serialize and deserialize the type.Notice:
Right now the BilrostAs macro requires that the annotated type must
implement
Default. This is needed since Bilrost requires that itcan create an
empty stateof that field.Stack created with Sapling. Best reviewed with ReviewStack.