Skip to content

fix(1585): enable query parallelism with 1 #3203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

fix(1585): enable query parallelism with 1 #3203

merged 1 commit into from
Apr 30, 2025

Conversation

lsytj0413
Copy link
Contributor

Fix: #1585

I think this issue have been fixed, test with config:

default-num-partitions = 4

[admin.query-engine]
query-parallelism = 1

and when run cmd:

./target/debug/restate  sql  'SELECT ss.id FROM sys_invocation_status ss LEFT JOIN sys_invocation_state sis ON ss.id = sis.id'

It output as:

0 rows. Query took 11.070458ms

@lsytj0413
Copy link
Contributor Author

@AhmedSoliman ptal

igalshilman
igalshilman requested changes Apr 30, 2025
View reviewed changes
igalshilman
igalshilman requested changes Apr 30, 2025
View reviewed changes
@lsytj0413
Copy link
Contributor Author

@igalshilman change to .unwrap_or(2) to use 2 as default when query-parallelism is not set.

igalshilman
igalshilman approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@igalshilman igalshilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lsytj0413 thank you very much for your contribution.
Looks good to me!

@igalshilman igalshilman merged commit 81a7da3 into restatedev:main Apr 30, 2025
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2025
@lsytj0413 lsytj0413 deleted the fix1585 branch May 1, 2025 00:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@igalshilman igalshilman igalshilman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[introspection] Query failure when query parallelism = 1
2 participants
@lsytj0413 @igalshilman