Efficiently pack metadata versions in network structs #3196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhamadazmy
reviewed
Apr 29, 2025
| in_response_to, | ||
| span_context: None, | ||
| /// Returns the version of the metadata for the given kind. | ||
| #[must_use] |
There was a problem hiding this comment.
Why is this a must_use ?
There was a problem hiding this comment.
it's a good habit for functions that have no side effects. If the only value of calling a function is its return value, then you'd want the linter to notify them if they aren't using the return value.
tillrohrmann
approved these changes
Apr 29, 2025
Leveraging the fact the Version::INVALID is 0 to pack the metadata versions better in memory. Version needs 4 bytes (u32) while Option<Version> needs 8. `PeerMetadataVersion` now needs 16 bytes instead of 32, same for `Header`. The other change is to let `MetadataVersions` keep track of the actual observed version of the peer as this might come handy for introspection later. This doesn't impact performance as we still only notify if the version is higher than our latest local view. ``` // intentionally empty ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leveraging the fact the Version::INVALID is 0 to pack the metadata versions better in memory. Version needs 4 bytes (u32) while Option needs 8.
PeerMetadataVersionnow needs 16 bytes instead of 32, same forHeader.The other change is to let
MetadataVersionskeep track of the actual observed version of the peer as this might come handy for introspection later. This doesn't impact performance as we still only notify if the version is higher than our latest local view.Stack created with Sapling. Best reviewed with ReviewStack.