Using Bilrost for GetNodeStatus messages #3172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhamadazmy
commented
Apr 17, 2025
| #[prost(target = "crate::protobuf::cluster::RunMode")] | ||
| #[strum(serialize_all = "snake_case")] | ||
| pub enum RunMode { | ||
| Leader, | ||
| Follower, | ||
| Follower = 0, |
There was a problem hiding this comment.
Bilrost requires numeric enums to have an "EmptyState" which is always the variant with zero value. It's up to us to introduce Unknown variant (like what we do with protobuf) or assign the 0 value to one of the existing variants.
5172955 to
2fa50cc
Compare
1c9a326 to
08b4d59
Compare
0f73075 to
b1cbba0
Compare
5ed1d99 to
d132aae
Compare
AhmedSoliman
approved these changes
Apr 29, 2025
| @@ -12,6 +12,7 @@ use std::collections::BTreeMap; | |||
| use std::time::{Duration, Instant}; | |||
|
|
|||
| use prost_dto::IntoProst; | |||
| use restate_encoding::NetSerde; | |||
There was a problem hiding this comment.
it'd be ever-so-slightly nicer if this follows our import ordering convention.
Also introduce two new derive macros: - `BilrostNewType` to use with all ID types or any tuple with a single item. This will effectively flatten this tuple to its inner type. Given that the inner field is bilrost serializable - `NetworkMessage` which must be derived for each message that is going to be send over the network
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Bilrost for GetNodeStatus messages
Stack created with Sapling. Best reviewed with ReviewStack.