Skip to content

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented Apr 15, 2025

Copy link

github-actions bot commented Apr 15, 2025

Test Results

  7 files  ±0    7 suites  ±0   4m 44s ⏱️ -4s
 54 tests ±0   53 ✅ ±0  1 💤 ±0  0 ❌ ±0 
223 runs  ±0  220 ✅ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit 3c8df41. ± Comparison against base commit 71758bc.

♻️ This comment has been updated with latest results.

@AhmedSoliman AhmedSoliman force-pushed the pr3165 branch 2 times, most recently from 56dd1c8 to 17f5182 Compare April 16, 2025 08:34
@AhmedSoliman AhmedSoliman marked this pull request as ready for review April 16, 2025 08:35
@AhmedSoliman AhmedSoliman force-pushed the pr3165 branch 2 times, most recently from 35111a5 to da3e9d9 Compare April 16, 2025 14:44
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merging :-)

@@ -191,7 +191,7 @@ pub struct RaftOptions {
impl Default for RaftOptions {
fn default() -> Self {
RaftOptions {
raft_election_tick: NonZeroUsize::new(20).expect("20 to be non zero"),
raft_election_tick: NonZeroUsize::new(10).expect("20 to be non zero"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"10 to be non zero"

@AhmedSoliman AhmedSoliman force-pushed the pr3165 branch 2 times, most recently from e76782c to 30665fa Compare April 17, 2025 09:25
- Auto-recovery needs to be higher than http2 keep-alive timeout
- Shorter raft election timeout (~1-ish second)
@AhmedSoliman AhmedSoliman merged commit 3c8df41 into main Apr 22, 2025
51 checks passed
@AhmedSoliman AhmedSoliman deleted the pr3165 branch April 22, 2025 11:09
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants