Skip to content

Conversation

lsytj0413
Copy link
Contributor

Ref: #3036

before fix:

cargo clippy --manifest-path tools/restatectl/Cargo.toml --no-default-features --features no-trace-logging
error[E0599]: no variant or associated item named InMemory found for enum restate_types::logs::metadata::ProviderKind in the current scope
  --> tools/restatectl/src/commands/config/set.rs:78:27
   |
78 |             ProviderKind::InMemory | ProviderKind::Local => {
   |                           ^^^^^^^^ variant or associated item not found in ProviderKind

cc @tillrohrmann

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing the compilation of restatectl @lsytj0413. LGTM. Merging it now :-)

@tillrohrmann tillrohrmann merged commit bc75b38 into restatedev:main Apr 15, 2025
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2025
@tillrohrmann
Copy link
Contributor

@lsytj0413 not sure whether you have the permissions for it, but you might be able to ask for reviews in the top right corner of the UI. There is the field "reviewers". Not sure whether you can assign people there but if, then feel free to assign me. That way I do see the PRs that I need to review in my "review requests" overview which helps me not to forget PRs.

@lsytj0413 lsytj0413 deleted the fix-restatectl-compile-failed-with-only-no-traceing-logging branch April 15, 2025 23:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants