[chore] Use latest RocksDB table format version #3141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmedSoliman
approved these changes
Apr 14, 2025
|
There's a stricter checksum verification in v6 compared to v5 - as I understand it, certain errors like block reordering might previously have gone undetected, and will be more likely to get caught by v6, as well as extends the checksum verification to the SST footer. The latter is something I observed when building snapshots - I found that there were some areas in the footer that I could intentionally corrupt, and it would go undetected. But no major functional/performance changes or other direct benefits that I can tell. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been the default in RocksDB for over a year now:
facebook/rocksdb@bfd00bb