Improve forward compatibility for protocol version negotiation #3126
+18
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0cde59b to
054dd11
Compare
AhmedSoliman
approved these changes
Apr 10, 2025
Summary: This change ensures forward compatibility with newer protocol versions. Previously, if an unknown (i.e., future) version was receivied, negotiation would fail because it will be parsed as `ProtocolVersion::Unknown`. To fix this, the comparison is now performed using the raw version numbers (numeric) before converting to the concrete `ProtocolVersion` type. This allows the system to correctly determine the minimum version, even when one side uses an unrecognized newer version.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve forward compatibility for protocol version negotiation
Summary:
This change ensures forward compatibility with newer protocol versions.
Previously, if an unknown (i.e., future) version was receivied, negotiation would fail because it will be parsed as
ProtocolVersion::Unknown.To fix this, the comparison is now performed using the raw version numbers (numeric) before converting to the concrete
ProtocolVersiontype.This allows the system to correctly determine the minimum version, even when one side uses an unrecognized newer version.