[Chore] Remove replicated loglet feature #3120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5062e63 to
3daee8c
Compare
This commit simplifies how we use the local-loglet feature by limiting it to the Bifrost crate only. This has the advantage that restate-types can use ProviderKind::Local as the default value for the Bifrost provider. Moreover, it reduces the number of features that might be misconfigured which usually shows up at release time. This fixes restatedev#3118.
The replicated-loglet has now become the defacto recommended loglet to use. Therefore, we can simplify our feature matrix a little bit by letting all crates except for restate-bifrost activate this feature by default (and removing the option to not activate it).
3daee8c to
1af10bf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replicated-loglet has now become the defacto recommended loglet to use. Therefore,
we can simplify our feature matrix a little bit by letting all crates except for
restate-bifrost activate this feature by default (and removing the option to not
activate it).