Skip to content

Conversation

lsytj0413
Copy link
Contributor

Ref: #3036

before fix:

cargo clippy --manifest-path crates/bifrost/Cargo.toml --all-features

error[E0599]: no variant or associated item named `TestRunner` found for enum `restate_core::TaskKind` in the current scope
   --> crates/bifrost/src/loglet/loglet_tests.rs:127:47
    |
127 |         TaskCenter::spawn_unmanaged(TaskKind::TestRunner, "read", {
    |                                               ^^^^^^^^^^ variant or associated item not found in `TaskKind`

@muhamadazmy muhamadazmy requested a review from AhmedSoliman April 1, 2025 06:54
@lsytj0413 lsytj0413 force-pushed the fix-bifrost-compile-failed-with-all-features branch from 6c94282 to 7f45f71 Compare April 1, 2025 10:08
Copy link
Contributor

@AhmedSoliman AhmedSoliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's get this merged after we cut v1.3

@tillrohrmann tillrohrmann merged commit 13e983e into restatedev:main Apr 10, 2025
24 of 25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2025
@lsytj0413 lsytj0413 deleted the fix-bifrost-compile-failed-with-all-features branch April 10, 2025 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants