Skip to content

fix: make tracing-instrumentation compile with features prometheus #3034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

fix: make tracing-instrumentation compile with features prometheus #3034

merged 1 commit into from
Apr 10, 2025

Conversation

lsytj0413
Copy link
Contributor

@lsytj0413 lsytj0413 commented Mar 29, 2025 •
edited
Loading

Ref: #3036

cargo clippy --manifest-path crates/tracing-instrumentation/Cargo.toml --no-default-features --features prometheus

   --> crates/tracing-instrumentation/src/prometheus_metrics.rs:87:30
    |
87  |                 tokio::task::Builder::new()
    |                              ^^^^^^^ could not find `Builder` in `task`
    |
note: found an item that was configured out

@lsytj0413 lsytj0413 force-pushed the fix-tracing-features-dep branch from 3287a1f to 5021c0d Compare April 1, 2025 10:45
tillrohrmann
tillrohrmann approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the required features @lsytj0413. LGTM. Merging it now :-)

@tillrohrmann tillrohrmann merged commit c5d2c3b into restatedev:main Apr 10, 2025
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2025
@lsytj0413 lsytj0413 deleted the fix-tracing-features-dep branch April 10, 2025 13:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsytj0413 @tillrohrmann