Skip to content

fix: make service-protocol compile with --all-features #3033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

fix: make service-protocol compile with --all-features #3033

merged 1 commit into from
Apr 10, 2025

Conversation

lsytj0413
Copy link
Contributor

@lsytj0413 lsytj0413 commented Mar 29, 2025 •
edited
Loading

Ref: #3036

Before this pr:

cargo clippy --manifest-path crates/service-protocol/Cargo.toml --all-features

crates/service-protocol/src/codec.rs:253:55
    |
253 |                     let invocation_id = InvocationId::mock_random();
    |                                                       ^^^^^^^^^^^ function or associated item not found in `InvocationId`

@lsytj0413 lsytj0413 force-pushed the fix-servive-protocol-compile-failed branch from df187e6 to dbd8a5c Compare April 1, 2025 10:43
tillrohrmann
tillrohrmann reviewed Apr 10, 2025
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this problem @lsytj0413. I had a question regarding the "codec" feature.

crates/service-protocol/Cargo.toml Outdated
@@ -12,21 +12,21 @@ default = []
codec = ["dep:restate-types", "dep:paste"]
discovery = ["dep:serde", "dep:serde_json", "dep:bytestring", "dep:regress", "dep:tracing", "dep:codederror", "dep:restate-errors", "dep:http", "dep:http-body-util", "dep:restate-service-client", "dep:restate-types", "dep:tokio"]
message = ["dep:restate-types", "dep:bytes-utils", "dep:codederror", "dep:restate-errors", "dep:size", "dep:tracing"]
test-util = []
test-util = ["codec", "restate-types/test-util"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is "codec" needed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing that out. It was unnecessary, and I have already deleted it.

@lsytj0413 lsytj0413 force-pushed the fix-servive-protocol-compile-failed branch from dbd8a5c to f534b13 Compare April 10, 2025 13:54
@tillrohrmann tillrohrmann merged commit 7de5ed3 into restatedev:main Apr 10, 2025
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2025
@lsytj0413 lsytj0413 deleted the fix-servive-protocol-compile-failed branch April 10, 2025 23:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsytj0413 @tillrohrmann