fix(3004): use scope for async function #3010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's very strange |
There was a problem hiding this comment.
Thanks for fixing this problem @lsytj0413. I think we can use the TaskCenterFutureExt::in_tc call here.
| @@ -58,7 +58,7 @@ where | |||
| .expect("task_center builds") | |||
| .into_handle(); | |||
|
|
|||
| let result = task_center.run_sync(|| fn_body(config)).await; | |||
| let result = task_center.run_async(|| fn_body(config)).await; | |||
There was a problem hiding this comment.
The way to run the fn_body generated future in the task center context can be expressed via
let result = fn_body(config).in_tc(&task_center).await;
There was a problem hiding this comment.
Thanks for your advise, fixed.
tillrohrmann
approved these changes
Apr 11, 2025
There was a problem hiding this comment.
Thanks for updating the PR so quickly @lsytj0413. LGTM. Merging it now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #3004