Reduce metrics cardinality and limit some metrics to debug builds #3638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 6, 2025
Test Results 7 files ±0 7 suites ±0 3m 40s ⏱️ -6s For more details on these errors, see this check. Results for commit fb00afb. ± Comparison against base commit bb835b4. ♻️ This comment has been updated with latest results. |
muhamadazmy
approved these changes
Aug 6, 2025
Comment on lines
64
to
79
| #[cfg(debug_assertions)] | ||
| let labels = [("runtime", runtime.clone())]; | ||
| #[cfg(debug_assertions)] | ||
| gauge!("restate.tokio.num_workers", &labels).set(stats.num_workers() as f64); | ||
| #[cfg(debug_assertions)] | ||
| gauge!("restate.tokio.blocking_threads", &labels).set(stats.num_blocking_threads() as f64); | ||
| #[cfg(debug_assertions)] | ||
| gauge!("restate.tokio.blocking_queue_depth", &labels).set(stats.blocking_queue_depth() as f64); | ||
| #[cfg(debug_assertions)] | ||
| gauge!("restate.tokio.num_alive_tasks", &labels).set(stats.num_alive_tasks() as f64); | ||
| #[cfg(debug_assertions)] | ||
| gauge!("restate.tokio.io_driver_ready_count", &labels) | ||
| .set(stats.io_driver_ready_count() as f64); | ||
| gauge!("restate.tokio.remote_schedule_count", "runtime" => runtime.clone()) | ||
| .set(stats.remote_schedule_count() as f64); | ||
| #[cfg(debug_assertions)] | ||
| counter!("restate.tokio.remote_schedule_count", &labels) | ||
| .absolute(stats.remote_schedule_count()); |
There was a problem hiding this comment.
Maybe group everything in a closure like
#[cfg(debug_assertion)]
{
gauge!(..);
...
}This has been causing memory leak if it's set to zero so we are removing and it can be later re-introduced if its underlying issues are fixed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack created with Sapling. Best reviewed with ReviewStack.