Skip to content

Remove histogram timeout configuration option #3637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 6, 2025
Merged

Remove histogram timeout configuration option #3637

merged 3 commits into from
Aug 6, 2025

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented Aug 6, 2025 •
edited
Loading

This has been causing memory leak if it's set to zero so we are removing and it can be later re-introduced if its underlying issues are fixed.

Stack created with Sapling. Best reviewed with ReviewStack.

This was referenced Aug 6, 2025
Merged
Merged
Open
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2025 •
edited
Loading

Test Results

 5 files   -   2   5 suites   - 2   1m 9s ⏱️ - 2m 37s
25 tests  -  29  25 ✅  -  28  0 💤  - 1  0 ❌ ±0 
34 runs   - 189  34 ✅  - 186  0 💤  - 3  0 ❌ ±0 

Results for commit f6487e9. ± Comparison against base commit bb835b4.

This pull request removes 54 and adds 25 tests. Note that renamed tests count towards both. 
dev.restate.sdktesting.tests.CallOrdering ‑ ordering(boolean[], Client)[1]
dev.restate.sdktesting.tests.CallOrdering ‑ ordering(boolean[], Client)[2]
dev.restate.sdktesting.tests.CallOrdering ‑ ordering(boolean[], Client)[3]
dev.restate.sdktesting.tests.Cancellation ‑ cancelFromAdminAPI(BlockingOperation, Client, URI)[1]
dev.restate.sdktesting.tests.Cancellation ‑ cancelFromAdminAPI(BlockingOperation, Client, URI)[2]
dev.restate.sdktesting.tests.Cancellation ‑ cancelFromAdminAPI(BlockingOperation, Client, URI)[3]
dev.restate.sdktesting.tests.Cancellation ‑ cancelFromContext(BlockingOperation, Client)[1]
dev.restate.sdktesting.tests.Cancellation ‑ cancelFromContext(BlockingOperation, Client)[2]
dev.restate.sdktesting.tests.Cancellation ‑ cancelFromContext(BlockingOperation, Client)[3]
dev.restate.sdktesting.tests.Combinators ‑ awakeableOrTimeoutUsingAwaitAny(Client)
…

dev.restate.sdktesting.tests.AwakeableIngressEndpointTest ‑ completeWithFailure(Client)
dev.restate.sdktesting.tests.AwakeableIngressEndpointTest ‑ completeWithSuccess(Client)
dev.restate.sdktesting.tests.BackCompatibilityTest$NewVersion ‑ createAwakeable(Client)
dev.restate.sdktesting.tests.BackCompatibilityTest$NewVersion ‑ startOneWayProxyCall(Client)
dev.restate.sdktesting.tests.BackCompatibilityTest$NewVersion ‑ startProxyCall(Client)
dev.restate.sdktesting.tests.BackCompatibilityTest$NewVersion ‑ startRetryableOperation(Client)
dev.restate.sdktesting.tests.BackCompatibilityTest$OldVersion ‑ completeAwakeable(Client)
dev.restate.sdktesting.tests.BackCompatibilityTest$OldVersion ‑ completeRetryableOperation(Client)
dev.restate.sdktesting.tests.BackCompatibilityTest$OldVersion ‑ proxyCallShouldBeDone(Client)
dev.restate.sdktesting.tests.BackCompatibilityTest$OldVersion ‑ proxyOneWayCallShouldBeDone(Client)
…

♻️ This comment has been updated with latest results.

muhamadazmy
muhamadazmy requested changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@muhamadazmy muhamadazmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we need to do this over proper deprecation mechanism. This change will cause config loading issues, unless we are 100% sure this flag was never set by the users.

@AhmedSoliman
Copy link
Contributor Author

@muhamadazmy what do you mean by config loading issues? we never fail on unknown fields in config.

@AhmedSoliman
Do not overshoot iterator allocations
b826422
@AhmedSoliman
[chore] Upgrade metrics crates
7113bd5
@AhmedSoliman
Remove histogram timeout configuration option
f6487e9 
This has been causing memory leak if it's set to zero so we are removing and it can be later re-introduced if its underlying issues are fixed.
@AhmedSoliman AhmedSoliman merged commit f6487e9 into main Aug 6, 2025
57 checks passed
@AhmedSoliman AhmedSoliman deleted the pr3637 branch August 6, 2025 16:56
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@muhamadazmy muhamadazmy muhamadazmy approved these changes

@jackkleeman jackkleeman Awaiting requested review from jackkleeman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AhmedSoliman @muhamadazmy