Update currently applied DB configuration values after reload #3627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 7 files ± 0 7 suites ±0 2m 48s ⏱️ - 2m 4s Results for commit 66de839. ± Comparison against base commit 34321b6. This pull request removes 2 tests.♻️ This comment has been updated with latest results. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this was missed in the original change. Without saving the new options, changing them again works only as long as the new values are not reverted to the originally loaded values. E.g. changing
rocksdb-enable-stall-on-memory-limitfromfalsetotrueworks, but cannot be reverted back tofalsewithout a restart. It also incorrectly reports settings as changed if unrelated options change.