[Replicated metadata server] Ensure that latest NodesConfiguration is known to MetadataManager #3600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit splits the very large server.rs file into standby.rs and member.rs which live in the server module.
… known to MetadataManager This commit ensures that the latest NodesConfiguration is known to the MetadataManager when exiting the Member role. This ensures that the Standby role works on the latest NodesConfiguration.
526948b to
e67c936
Compare
|
A slightly better, yet more involved change, would be to pass the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that the latest NodesConfiguration is known to the MetadataManager when exiting the
Member role. This ensures that the Standby role works on the latest NodesConfiguration.
Only the last commit is relevant. The first commit adds a little bit more logging output and the second commit splits the server.rs into smaller files.