Mock service endpoint uses protocol v5 #3586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ea9097f to
4439ea8
Compare
|
Tested locally too and it works fine |
tillrohrmann
approved these changes
Jul 29, 2025
There was a problem hiding this comment.
Thanks a lot for porting the mock service endpoint to service protocol v5 @slinkydeveloper. The changes look good to me and when trying it out it worked really well :-) Merging it now.
| Entry::SetState(set) = set | ||
| ); | ||
| Message::SetStateCommand(set_state_bytes) => { | ||
| let set = RawCommand::new(CommandType::SetState, set_state_bytes.clone()).decode::<ServiceProtocolV4Codec, SetStateCommand>()?; | ||
| set.value.clone() |
There was a problem hiding this comment.
We might not need .clone() here.
4439ea8 to
f992b69
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated mock service endpoint to use protocol V5