Schema registry changes #3550
Schema registry changes #3550
Conversation
|
Tested locally bumping the version of Restate here to |
1a40491 to
644c9f7
Compare
644c9f7 to
23415a8
Compare
| use crate::{Version, Versioned, identifiers}; | ||
| use arc_swap::ArcSwapOption; | ||
| use restate_serde_util::MapAsVecItem; | ||
| use serde_json::Value; |
There was a problem hiding this comment.
nit: I'd appreciate if imports are organized according to our convention.
There was a problem hiding this comment.
As said in other PRs, I'll be happy to do that with a tool that automates it.
1d32638 to
b0ec13f
Compare
b0ec13f to
c36a867
Compare
c36a867 to
9874d90
Compare
| id: DeploymentId, | ||
| ty: DeploymentType, | ||
| delivery_options: DeliveryOptions, | ||
| supported_protocol_versions: RangeInclusive<i32>, |
There was a problem hiding this comment.
Can protocol versions be negative?
There was a problem hiding this comment.
nope. I suppose this came from
There was a problem hiding this comment.
i would probably leave this as it is for now, and reconsider it in 1.6
There was a problem hiding this comment.
I'm hoping that we'll reduce the number of allocations/clones/copies with future changes and carefully design the type structure for efficient memory/cpu use. I don't have objections against the change but I don't particularly see it as improvement over the existing design.
437197e to
db18c60
Compare
This commit contains the changes described in restatedev#3303 * metadata contains the "implementation" of the schema registry, and the serializable data structure `Schema`. * `metadata/mod.rs` contains the definition of `Schema` and the implementation of the various schema registry APIs. All the fields are private, and access should be available only through schema registry APIs or `SchemaUpdater`. * `Schema` now uses the new data types from the old `v2.rs` file. On deserialization, we infer the "active service revisions" index (the logic for that is within `serde_hacks`). * `v2.rs` conversions was moved to `metadata/serde_hacks.rs`, the new data model is directly in `metadata/mod.rs`. Inside it, I moved the old data types *Schemas, which should not be used anymore. * `SchemaUpdater` was moved inside `metadata`, and deals with the new `Schema` data structure. The behavior remains untouched. * Switch default writing using the new schema data structure Everything else is more or less copying stuff around and renaming.
db18c60 to
1434d9d
Compare
Fix #3303