Skip to content

A lot of compiled failed with each-features #3036

@lsytj0413

Description

@lsytj0413

When we run clippy on each features(cargo hack clippy --each-feature --keep-going --exclude-no-default-features), we will go a lot of compile failed:

error: failed to run 17 commands

failed commands:
    restate-admin:
        `cargo clippy --manifest-path crates/admin/Cargo.toml --no-default-features --features clients`
        `cargo clippy --manifest-path crates/admin/Cargo.toml --no-default-features --features memory-loglet`
        `cargo clippy --manifest-path crates/admin/Cargo.toml --no-default-features --features metadata-api`
        `cargo clippy --manifest-path crates/admin/Cargo.toml --no-default-features --features options_schema`
        `cargo clippy --manifest-path crates/admin/Cargo.toml --no-default-features --features serve-web-ui`
        `cargo clippy --manifest-path crates/admin/Cargo.toml --no-default-features --features storage-query`
    restate-bifrost:
        `cargo clippy --manifest-path crates/bifrost/Cargo.toml --all-features`
        `cargo clippy --manifest-path crates/bifrost/Cargo.toml --no-default-features --features test-util`
    restate-invoker-impl:
        `cargo clippy --manifest-path crates/invoker-impl/Cargo.toml --all-features`
        `cargo clippy --manifest-path crates/invoker-impl/Cargo.toml --no-default-features --features default`
        `cargo clippy --manifest-path crates/invoker-impl/Cargo.toml --no-default-features --features options_schema`
    restate-service-protocol:
        `cargo clippy --manifest-path crates/service-protocol/Cargo.toml --all-features`
    restate-tracing-instrumentation:
        `cargo clippy --manifest-path crates/tracing-instrumentation/Cargo.toml --no-default-features --features prometheus`
    restate-wal-protocol:
        `cargo clippy --manifest-path crates/wal-protocol/Cargo.toml --no-default-features --features options_schema`
    restatectl:
        `cargo clippy --manifest-path tools/restatectl/Cargo.toml --no-default-features --features memory-loglet`
        `cargo clippy --manifest-path tools/restatectl/Cargo.toml --no-default-features --features no-trace-logging`
        `cargo clippy --manifest-path tools/restatectl/Cargo.toml --no-default-features --features replicated-loglet`

I think even those crate is only used in this project as inner dependency, they should compile success with any valid features cfg.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions