Skip to content

Update types and jsdocs #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 23, 2025
Merged

Update types and jsdocs #2232

merged 3 commits into from
Apr 23, 2025

Conversation

zAlweNy26
Copy link
Contributor

Fix #2231

I hope I haven't missed (or messed up) anything :)

I didn't understand why there are execOptions both at first level of the settings object and also nested inside execOptions, or did I understand wrong?

@netlify Netlify
Copy link

netlify bot commented Oct 13, 2024 •
edited
Loading

✅ Deploy Preview for nodemon ready!

Name Link
🔨 Latest commit e205557
🔍 Latest deploy log https://app.netlify.com/sites/nodemon/deploys/678cf4caf9e6a00008f93a30
😎 Deploy Preview https://deploy-preview-2232--nodemon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ravin00
ravin00 reviewed Oct 26, 2024
View reviewed changes
remy added a commit that referenced this pull request Dec 13, 2024
@remy
fix: types updated
cb91187 
Created by @zAlweNy26
PR: #2232

Modified commit to allow for squash and conventional commit
@jlowcs
Copy link

jlowcs commented Jan 14, 2025 •
edited
Loading

Following this change, delay option has disappeared and watch and ignore options are duplicated :/

@remy
Copy link
Owner

remy commented Jan 14, 2025

Following this change, delay option has disappeared and watch and ignore options are duplicated :/

By this change are you referring to this: https://github.com/remy/nodemon/pull/2232/files ?

Or have you pulled down this PR directly and are testing it?

@jlowcs
Copy link

jlowcs commented Jan 14, 2025

Following this change, delay option has disappeared and watch and ignore options are duplicated :/

By this change are you referring to this: https://github.com/remy/nodemon/pull/2232/files ?

Or have you pulled down this PR directly and are testing it?

I'm using the latest version of nodemon and am encountering the type checking issues mentioned above.

@zAlweNy26
Copy link
Contributor Author

@remy I fixed the errors @jlowcs is talking about. Also now the export is correct.

@lcxmaple
Copy link

Is there any progress on this matter? If any code is used like this after update to version 3.1.8

import nodemon from 'nodemon'

nodemon({
  script: ''
})

then you will get a typescript error "Type 'Nodemon' has no call signatures."

It works perfectly fine in version 3.1.7.

@remy remy merged commit 297c7c7 into remy:main Apr 23, 2025
4 checks passed
@remy
Copy link
Owner

remy commented Apr 23, 2025

Jeez, sorry this took me so long to merge.

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.1.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jlowcs
Copy link

jlowcs commented May 12, 2025

Was the watch option removed by mistake?

@remy
Copy link
Owner

remy commented May 12, 2025

Was the watch option removed by mistake?

I suspect that's the case, it's certainly still there in JS-land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@ravin00 ravin00 ravin00 left review comments

@Axorax Axorax Axorax approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing types
6 participants
@zAlweNy26 @jlowcs @remy @lcxmaple @Axorax @ravin00