Skip to content

Fix GitLab secure configuration default value #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

AlejandroRM-DEV
Copy link
Contributor

@AlejandroRM-DEV AlejandroRM-DEV commented May 30, 2025

Problem

The documentation states that gitlab.secure has a default value of false:

gitlab.secure: Flag to disable server certificate verification (default: `false`) 

However, the actual default value is null, which causes the following comparison to evaluate incorrectly:

const needsCustomAgent = Boolean(secure === false || certificateAuthorityFile);

When secure is null, the condition secure === false returns false, leading to unexpected behavior in the custom agent logic.

Solution

  • Updated the default value of secure to false in both the GitLab configuration and schema
  • This ensures consistency between the documented behavior and actual implementation

Additional Changes

  • Updated documentation to clarify that GitLab tokens require api and self_rotate scopes

Example

- Document that GitLab token requires `api` and `self_rotate` scopes
- Set default `secure` value to false in GitLab configuration and schema
Copy link

pkg-pr-new bot commented May 30, 2025

Open in StackBlitz

npm i https://pkg.pr.new/release-it@1229

commit: 1958333

@webpro
Copy link
Collaborator

webpro commented May 30, 2025

Thanks for the catch & the fix, Alejandro! 👌

@webpro webpro merged commit 9c7d2b3 into release-it:main May 30, 2025
10 checks passed
@webpro
Copy link
Collaborator

webpro commented May 30, 2025

🚀 This pull request is included in v19.0.3. See Release 19.0.3 for release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants