test(web): move e2e tests from web project to separate e2e project #1693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR extracts end-to-end tests from the web project into a standalone e2e project, streamlining test configuration and tooling.
- Relocated all E2E test files under
e2e/testsand updated imports accordingly - Added lint, fix, and format scripts plus ESLint/Prettier configs
- Updated GitHub Actions workflow to target the new
e2edirectory
Reviewed Changes
Copilot reviewed 9 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| e2e/tests/projects.spec.ts | Cleaned up imports and added ESLint disables for empty destructure |
| e2e/tests/login.spec.ts | Added ESLint disable to ignore unused fixture destructure |
| e2e/tests/dashboard.spec.ts | Same empty-pattern disables and removal of unused variable lines |
| e2e/pages/projectsPage.ts | Removed unused path import |
| e2e/pages/projectScreenPage.ts | Removed unused FrameLocator import |
| e2e/package.json | Introduced lint/fix/format scripts and ESLint plugins |
| e2e/eslint.config.mjs | Added project-specific ESLint configuration |
| e2e/.prettierrc | Set Prettier trailingComma rule |
| .github/workflows/playwright_ui_tests.yml | Updated working-directory from web/e2e to e2e |
Comments suppressed due to low confidence (1)
e2e/package.json:34
- The
e2eproject’s package.json does not include@playwright/testorplaywrightin its dependencies/devDependencies. Without these, the tests will fail to run—please add them.
"dependencies": {
airslice
approved these changes
Jul 7, 2025
airslice
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What I've done
What I haven't done
How I tested
Which point I want you to review particularly
Memo