-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: reduxjs/react-redux
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.1.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: reduxjs/react-redux
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.0.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 17 commits
- 38 files changed
- 8 contributors
Commits on Oct 28, 2018
-
* Consistent naming for `mapStateToProps` * Add `mapDispatch` docs * Doc site configuration changes * Review resolutions
Configuration menu - View commit details
-
Copy full SHA for 7458311 - Browse repository at this point
Copy the full SHA 7458311View commit details
Commits on Nov 1, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 0e44ad1 - Browse repository at this point
Copy the full SHA 0e44ad1View commit details
Commits on Nov 6, 2018
-
Use React.createContext() by @cellog (#1000)
* alternate 6.x implementation * use canary values in store instead of setting a prop on the store * remove createProvider (missed this one before) * fix renderCountProp, add a test also clean up unused canary values * remove errant console.log * expose context consumer and provider This will allow third party apps to use these in their code * changes requested by @timdorr * export Context instead of just Consumer/Provider * fix error messages for removed functionality * minor displayName change * keep prop-types in production minified UMD build when the time is right, one need only change the BABEL_ENV for build:umd:min back to "rollup-production" * performance optimizations: HEADS UP API change too * React.forwardRef is VERY slow, on the order of 2x slower in our benchmark. So we only enable it if withRef="forwardRef" folks using withRef=true will get an error telling them to update and not rely on getWrappedInstance() but just to use the ref directly * renderCountProp is removed, as this is natively supported in React dev tools now * all usages of shallowEquals are removed for pure components, it was unnecessary. * instead of allowing passing in a custom Context consumer in props, it is now required to be passed in via connect options at declaration time. * small optimizations/refactors * fix storeKey error, allow unstable_observedBits * update hoist-non-react-statics * cosmetics * Replace `withRef="fowardRef"` option with `forwardRef=true` * Less package-lock.json noise * Bump React dep to 16.6, and remove shallow-equals * Switch context variable and prop naming, and use the whole object * Update Provider implementation and use storeState field * Rework Provider tests * Rework connect tests, combine warnings, and remove observedBits Ported connect test handling from 995 Deduped the "custom store context" messages Removed use of observedBits for now Commented out derivedProps propTypes that caused test failures * Rework connect component based on review notes Removed use of PureWrapper Used React.memo() on the wrapped component Renamed and extracted makeDerivedPropsSelector Added makeChildElementSelector Simplified render props callback Simplified forwardRef handling * Fix tests around custom context * Fix custom context as a prop usage * Fix lint warnings * Run through Prettier. Update lockfile.
5Configuration menu - View commit details
-
Copy full SHA for 85fb553 - Browse repository at this point
Copy the full SHA 85fb553View commit details -
* Use Prettier * Make sure linting and formatting are part of the testing process. * Run prettier on existing code.
Configuration menu - View commit details
-
Copy full SHA for 0c048f0 - Browse repository at this point
Copy the full SHA 0c048f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a92b56 - Browse repository at this point
Copy the full SHA 1a92b56View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7496b91 - Browse repository at this point
Copy the full SHA 7496b91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59aaba5 - Browse repository at this point
Copy the full SHA 59aaba5View commit details
Commits on Nov 10, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 8987de0 - Browse repository at this point
Copy the full SHA 8987de0View commit details
Commits on Nov 11, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 1dc56ca - Browse repository at this point
Copy the full SHA 1dc56caView commit details -
Add connectAdvanced() tests (#1079)
Since the connectAdvanced() is a public api I think it should have some tests. Unfortunately these tests are intentionally failing because I'm not sure how connectAdvanved() should really work. This is just my best guess. For example the behaviour is very different between 5.x and 6 beta. Different tests fail between those and in common failures the errors are different. I have created [redux-render-prop](https://github.com/epeli/redux-render-prop) module which relies on the connectAdvanced() primitive and I noticed that all the important performance related [tests started failing](https://travis-ci.com/epeli/redux-render-prop/jobs/157787740) when I upgraded to 6 beta. Most importantly [`unrelated state updates don't cause render`](https://github.com/epeli/redux-render-prop/blob/aa2aa9b299e5859f7a79bc1c926ed75907f63dcb/__tests__/redux-render-prop.test.tsx#L284-L349). I've added matching test in this PR called `should not render when the returned reference does not change`. I've also observed that in 5.x the state mapping function gets called twice on component mount for which I had to create [a very ugly workaround](https://github.com/epeli/redux-render-prop/blob/aa2aa9b299e5859f7a79bc1c926ed75907f63dcb/src/redux-render-prop.ts#L188-L195) in redux-render-prop to avoid unnecessary rendering. I've added test for that case too (`should map state and render once on mount`). This seems to be fixed in the 6 beta. I hope we can have more stable behaviour for the connectAdvanced() in future.
Configuration menu - View commit details
-
Copy full SHA for dba598b - Browse repository at this point
Copy the full SHA dba598bView commit details
Commits on Nov 19, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 6a2e878 - Browse repository at this point
Copy the full SHA 6a2e878View commit details
Commits on Nov 23, 2018
-
Configuration menu - View commit details
-
Copy full SHA for f0840f1 - Browse repository at this point
Copy the full SHA f0840f1View commit details
Commits on Dec 2, 2018
-
Configuration menu - View commit details
-
Copy full SHA for ce17d0c - Browse repository at this point
Copy the full SHA ce17d0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for cf11a25 - Browse repository at this point
Copy the full SHA cf11a25View commit details
Commits on Dec 3, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 7564f73 - Browse repository at this point
Copy the full SHA 7564f73View commit details
Commits on Dec 4, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 9062722 - Browse repository at this point
Copy the full SHA 9062722View commit details
Commits on Dec 5, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 581ece4 - Browse repository at this point
Copy the full SHA 581ece4View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v5.1.0...v6.0.0