Skip to content

[v24.3.x] kc/consumer: fixed resource leak when coordinator changes #26599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

[v24.3.x] kc/consumer: fixed resource leak when coordinator changes #26599

merged 1 commit into from
Jun 27, 2025
+10 −2

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #26567

@mmaslankaprv @vbotbuildovich
kc/consumer: fixed resource leak when coordinator changes
87ffcae 
Each `kafka::client::consumer` owns a separate coordinator broker connection.
When coordinator changes the connection is exchanged with the new one.
Currently the connection is not closed which may lead to a resource
leak.

Signed-off-by: Michał Maślanka <michal@redpanda.com>
(cherry picked from commit 4f601a4)
@vbotbuildovich vbotbuildovich added this to the v24.3.x-next milestone Jun 26, 2025
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Jun 26, 2025
@vbotbuildovich
Copy link
Collaborator Author

CI test results

test results on build#67993
test_class test_method test_arguments test_kind job_url test_status passed reason
distributed_kv_stm_tests_rpunit distributed_kv_stm_tests_rpunit unit https://buildkite.com/redpanda/redpanda/builds/67993#0197ad04-899d-44c7-aff9-bb34755ea012 FLAKY 1/2
gtest_cloud_storage_rpfixture gtest_cloud_storage_rpfixture unit https://buildkite.com/redpanda/redpanda/builds/67993#0197ad04-899e-42f1-ab14-f92102098ba2 FLAKY 1/2
CloudArchiveRetentionTest test_delete {"cloud_storage_type": 2, "retention_type": "retention.ms"} ducktape https://buildkite.com/redpanda/redpanda/builds/67993#0197ad5f-3f93-4c48-940f-e51616fcc449 FAIL 0/1
CloudArchiveRetentionTest test_delete {"cloud_storage_type": 1, "retention_type": "retention.ms"} ducktape https://buildkite.com/redpanda/redpanda/builds/67993#0197ad43-e181-446b-b04e-f982c1e5e734 FLAKY 17/21 upstream reliability is '95.0'. current run reliability is '80.95238095238095'. drift is 14.04762 and the allowed drift is set to 50. The test should PASS
CloudRetentionTest test_cloud_retention {"cloud_storage_type": 2, "max_consume_rate_mb": null} ducktape https://buildkite.com/redpanda/redpanda/builds/67993#0197ad5f-3f92-4628-8520-92b16383a58f FLAKY 20/21 upstream reliability is '100.0'. current run reliability is '95.23809523809523'. drift is 4.7619 and the allowed drift is set to 50. The test should PASS
CompactionGapsTest test_translation_no_gaps {"cloud_storage_type": 1} ducktape https://buildkite.com/redpanda/redpanda/builds/67993#0197ad5f-3f96-41e1-87f7-bd47fd0e9922 FLAKY 10/21 upstream reliability is '57.99999999999999'. current run reliability is '47.61904761904761'. drift is 10.38095 and the allowed drift is set to 50. The test should PASS
ShadowIndexingWhileBusyTest test_create_or_delete_topics_while_busy {"cloud_storage_type": 2, "short_retention": true} ducktape https://buildkite.com/redpanda/redpanda/builds/67993#0197ad5f-3f93-4c48-940f-e51616fcc449 FLAKY 9/12

@mmaslankaprv mmaslankaprv merged commit 1197b81 into redpanda-data:v24.3.x Jun 27, 2025
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmaslankaprv mmaslankaprv mmaslankaprv approved these changes

Assignees
No one assigned
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v24.3.x-next
Development

Successfully merging this pull request may close these issues.
2 participants
@vbotbuildovich @mmaslankaprv