Fix bug in PFMERGE command #13672
Merged
Fix bug in PFMERGE command #13672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuyang Wang <xuyangwang@link.cuhk.edu.cn>
Signed-off-by: Xuyang Wang <xuyangwang@link.cuhk.edu.cn>
Signed-off-by: Xuyang Wang <xuyangwang@link.cuhk.edu.cn>
|
|
Signed-off-by: Xuyang Wang <xuyangwang@link.cuhk.edu.cn>
sundb
reviewed
Dec 8, 2024
Co-authored-by: debing.sun <debing.sun@redis.com>
|
@ShooterIT no, because #13558 doesn't release. |
|
I don't mean we mention bug fix instead of new sub command |
|
@ShooterIT you're right, we should add release note label for sub command. |
|
Hi @YaacovHazan I want to merge this PR. Even this PR introduces a subcommand |
YaacovHazan
pushed a commit
that referenced
this pull request
Jan 14, 2025
The bug was introduced in #13558 . When merging dense hll structures, `hllDenseCompress` writes to wrong location and the result will be zero. The unit tests didn't cover this case. This PR + fixes the bug + adds `PFDEBUG SIMD (ON|OFF)` for unit tests + adds a new TCL test to cover the cases Synchronized from valkey-io/valkey#1293 --------- Signed-off-by: Xuyang Wang <xuyangwang@link.cuhk.edu.cn> Co-authored-by: debing.sun <debing.sun@redis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was introduced in #13558 .
When merging dense hll structures,
hllDenseCompresswrites to wrong location and the result will be zero. The unit tests didn't cover this case.This PR
PFDEBUG SIMD (ON|OFF)for unit testsSynchronized from valkey-io/valkey#1293