Support v1 recipes in CrossPythonMigrator
#3832
Conversation
`CrossPythonMigrator` is not actually using anything from `CrossCompilationMigratorBase`, besides `post_migration` attribute, and calling the superclass `filter()` method yields incorrect results. Make the class inherit `MiniMigrator` instead to make it more consistent with other minimigrators.
Update `CrossPythonMigrator` for v1 recipes. Unfortunately, this yields
a bit suboptimal output, as it does not combine conditions:
```yaml
- if: build_platform != target_platform
then: python
- if: build_platform != target_platform
then: cross-python_${{ target_platform }}
- if: build_platform != target_platform
then: cython
```
That said, addressing this would increase the divergency between v0
and v1 code in the migrator, and `conda-recipe-manager convert` suffers
from the same issue. I think a better way forward would be to write
a dedicated v1 recipe migrator that combines adjacent conditions.
Part of bug regro#3642
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3832 +/- ##
==========================================
+ Coverage 77.03% 77.04% +0.01%
==========================================
Files 138 138
Lines 15394 15406 +12
==========================================
+ Hits 11859 11870 +11
- Misses 3535 3536 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
For cc @wolfv |
I see only |
|
The CEPs we have actually don't define what variables are allowed versus not in the selectors as far as I know. |
|
Updated this one to use |
|
@beckermr, gentle ping. Is there anything left blocking this PR? |
Description:
Update
CrossPythonMigratorfor v1 recipes. Unfortunately, this yieldsa bit suboptimal output, as it does not combine conditions:
That said, addressing this would increase the divergency between v0
and v1 code in the migrator, and
conda-recipe-manager convertsuffersfrom the same issue. I think a better way forward would be to write
a dedicated v1 recipe migrator that combines adjacent conditions.
Checklist:
Cross-refs, links to issues, etc:
Part of bug #3642