Support v1 recipes in CrossRBaseMigrator
#3836
Conversation
`CrossRBaseMigrator` is not actually using anything from `CrossCompilationMigratorBase`, besides `post_migration` attribute, and calling the superclass `filter()` method yields incorrect results. Make the class inherit `MiniMigrator` instead to make it more consistent with other minimigrators.
Add support for v1 recipes in `CrossRBaseMigrator`. Here the logic
made it easy to output a single combined condition:
```yaml
- if: build_platform != target_platform
then:
- cross-r-base ${{ r_base }}
- r-rlang
```
Part of bug regro#3642
| [ | ||
| " " * nspaces | ||
| + "- if: build_platform != target_platform\n", | ||
| " " * nspaces + " then:\n", | ||
| " " * nspaces + " - cross-r-base ${{ r_base }}\n", | ||
| ] |
There was a problem hiding this comment.
FWICS we could just append all the lines as a single element here, but I've figured out that since it's a list of lines by design, it's cleaner to add them separately.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3836 +/- ##
=======================================
Coverage 77.02% 77.03%
=======================================
Files 138 138
Lines 15384 15394 +10
=======================================
+ Hits 11850 11859 +9
- Misses 3534 3535 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sorry about that. Remember about it for Python, failed to remember here. |
|
We can merge this despite the target_platform versus host_platform issue since we'll need to change that everywhere including rattler later, and this won't happen for a while. Is that OK @isuruf? |
|
I don't see a reason to merge this as it is. It's a very simple change that I don't think requires a lot of work. |
|
Okay, I've just checked rattler-build and |
|
@beckermr, gentle ping. Is there anything left blocking this PR? |
|
Thanks! |
Description:
Add support for v1 recipes in
CrossRBaseMigrator. Here the logicmade it easy to output a single combined condition:
Checklist:
Cross-refs, links to issues, etc:
Part of bug #3642