Support recipe v1 in Build2HostMigrator #3808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3808 +/- ##
==========================================
- Coverage 77.73% 76.29% -1.45%
==========================================
Files 136 136
Lines 14779 14787 +8
==========================================
- Hits 11489 11282 -207
- Misses 3290 3505 +215 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
beckermr
reviewed
Mar 4, 2025
beckermr
reviewed
Mar 4, 2025
beckermr
reviewed
Mar 4, 2025
beckermr
reviewed
Mar 4, 2025
beckermr
requested changes
Mar 4, 2025
isuruf
previously requested changes
Mar 4, 2025
|
Well, either way is fine with me. I've figured out it makes sense to keep it, in case people |
|
I agree it can be dropped. For that, we need to remove it from the various bits of the make_migrators file. Once we do that we can merge. |
beckermr
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add support for v1 recipes in
Build2HostMigrator, and extend the relevant tests. I've also replaced the explicit schema version check with asuper()call.Checklist:
Cross-refs, links to issues, etc:
From the list on #3642