Skip to content

support IPv6 host #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2025
Merged

support IPv6 host #956

merged 2 commits into from
Jun 23, 2025

Conversation

JimmyMa
Copy link

@JimmyMa JimmyMa commented Jun 23, 2025 •
edited by sudo-bmitch
Loading

Fixes issue

Docker supports IPv6 address, for example: docker pull [fddd:1222:1222:1222::ac29:5a6a]:5000/test/test:latest , but regclient doesn't support it.

Describe the change

Changed types/ref/ref.go to parse IPv6 address, with this change the regctl supports IPv6 host as below:

regctl registry set [fddd:1222:1222:1222::ac29:5a6a]:443 --tls insecure
regctl registry set [fddd:1222:1222:1222::ac29:5a6a] --tls insecure
regctl repo list  [fddd:1222:1222:1222::ac29:5a6a]:443
regctl tag ls [fddd:1222:1222:1222::ac29:5a6a]/red/core
regctl image inspect [fddd:1222:1222:1222::ac29:5a6a]:443/test/test:latest

How to verify it

  1. Create a VM with IPv6
  2. Create a local registry: docker run -d -p 5000:5000 --restart always --name registry registry:2
  3. Run regctl against the IPv6 address of the local registry

Changelog text

  • Feat: Support IPv6 hosts.

Please verify and check that the pull request fulfills the following requirements

  • Tests have been added or not applicable
  • Documentation has been added, updated, or not applicable
  • Changes have been rebased to main
  • Multiple commits to the same code have been squashed

support IPv6 host
c4532ea 
Signed-off-by: Yun Feng Ma <yma@ddn.com>
@sudo-bmitch
Copy link
Contributor

Thanks, IPv6 support is certainly desired.

Looking at the distribution implementation, I'm seeing the following: distribution/reference@992adca

There's a bit of cleanup and reorg in the regexp needed in here. I'll follow up with some adjustments.

@sudo-bmitch sudo-bmitch self-assigned this Jun 23, 2025
@sudo-bmitch
Chore: refactor ref regexp
8db35d3 
This moves the port to a standalone piece that is appended to various registry syntaxes.
This also makes the IPv6 matching more strict on allowing "::" only in one part of the expression.

Signed-off-by: Brandon Mitchell <git@bmitch.net>
sudo-bmitch
sudo-bmitch approved these changes Jun 23, 2025
View reviewed changes
Copy link
Contributor

@sudo-bmitch sudo-bmitch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with changes. Let me know if the edits give you any issues.

@sudo-bmitch sudo-bmitch merged commit 58c2b2e into regclient:main Jun 23, 2025
4 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jun 30, 2025
Merged
@yeikel yeikel mentioned this pull request Jun 30, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudo-bmitch sudo-bmitch sudo-bmitch approved these changes

Assignees

@sudo-bmitch sudo-bmitch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JimmyMa @sudo-bmitch