Chore: Refactor cobra commands #915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps align the different commands with each other. - Variable names have been improved to be less confusing. - Flags have been sorted, and completion options added on some flags where missing. - Each command creates its own options to avoid default flag value conflicts. - Reusing a command under two paths is now done by calling that commands "new" function. - Global-but-not-really-global options have been moved to be associated with the specific commands that use them. Signed-off-by: Brandon Mitchell <git@bmitch.net>
e6cde7f to
288f2c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
Describe the change
This helps align the different commands with each other.
How to verify it
Most changes should not be user visible. And where changes are visible, like moving flags from global to a specific command, they should be an improvement. Examples on some of the aliased commands may be changed to show the primary command name.
Changelog text
Please verify and check that the pull request fulfills the following requirements