Fix: Do not request offline refresh token #893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves compatibility with broken auth token servers. Signed-off-by: Brandon Mitchell <git@bmitch.net>
sudo-bmitch
added a commit
to sudo-bmitch/regclient
that referenced
this pull request
Feb 12, 2025
This fixes a regression caused by PR regclient#893. Signed-off-by: Brandon Mitchell <git@bmitch.net>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
Fixes #865.
Describe the change
This removes an auth hop that was defaulting to a POST even when a refresh token isn't available, where many token servers do not support the POST. In the GET for a token, the request for an offline refresh token is removed. Requesting a new token will send the original credentials again rather than the refresh token. This improves compatibility with broken auth token servers.
How to verify it
Tests have been updated, and trace logs should show auth going directly to the GET request.
Changelog text
Please verify and check that the pull request fulfills the following requirements