Skip to content

Conversation

sudo-bmitch
Copy link
Contributor

Fixes issue

This is a prerequisite for #749.

Describe the change

This switches the default build tag from !nolegacy to legacy so the packages are disabled by default. Legacy packages may still be used with -tags legacy added to the build. However, they may be permanently removed in a future release, and migrating to the newer packages is recommended.

How to verify it

No changes should be visible for users that have moved off of deprecated packages.

Changelog text

  • Breaking: Disable legacy packages by default.

Please verify and check that the pull request fulfills the following requirements

  • Tests have been added or not applicable
  • Documentation has been added, updated, or not applicable
  • Changes have been rebased to main
  • Multiple commits to the same code have been squashed

Legacy packages may still be used with "-tags legacy" added to the build.
They may be permanently removed in a future release.

Signed-off-by: Brandon Mitchell <git@bmitch.net>
@sudo-bmitch sudo-bmitch merged commit 3a4d032 into regclient:main Nov 12, 2024
5 checks passed
@sudo-bmitch sudo-bmitch deleted the pr-legacy branch November 12, 2024 14:35
@sudo-bmitch sudo-bmitch added this to the v0.8.0 milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant