Feat: Consolidate warnings #810
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
Various requests return multiple warning messages if a registry outputs a warning header on every request.
Describe the change
When a registry returns a warning header on every request, clients should try to consolidate these.
How to verify it
Test with olareg:
olareg serve --store-type mem --warning "Ephemeral registry, content may be deleted"
Requests with
regctl
to that registry should return one warning per command.Changelog text
Please verify and check that the pull request fulfills the following requirements
Testing this would need something monitoring stderr for every test, and enabling a registry with warnings on every test. For now, this is just a best effort.