Skip to content

Conversation

sudo-bmitch
Copy link
Contributor

Fixes issue

Various requests return multiple warning messages if a registry outputs a warning header on every request.

Describe the change

When a registry returns a warning header on every request, clients should try to consolidate these.

How to verify it

Test with olareg:

olareg serve --store-type mem --warning "Ephemeral registry, content may be deleted"

Requests with regctl to that registry should return one warning per command.

Changelog text

  • Feat: Consolidate warnings.

Please verify and check that the pull request fulfills the following requirements

Testing this would need something monitoring stderr for every test, and enabling a registry with warnings on every test. For now, this is just a best effort.

  • Tests have been added or not applicable
  • Documentation has been added, updated, or not applicable
  • Changes have been rebased to main
  • Multiple commits to the same code have been squashed

When a registry returns a warning header on every request, clients should try to consolidate these.

Signed-off-by: Brandon Mitchell <git@bmitch.net>
@sudo-bmitch sudo-bmitch merged commit cfcb9c9 into regclient:main Aug 22, 2024
5 checks passed
@sudo-bmitch sudo-bmitch deleted the pr-dedup-warnings branch August 22, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant