Fix: Support auth on redirect #805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A registry server that is just a redirect to a real server that requires auth will now work. Previously, auth was only sent to the first server, now it is only sent to the server that performed the auth. The auth package itself was also refactored a bit, removing unneeded interfaces and reducing exported fields. Signed-off-by: Brandon Mitchell <git@bmitch.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
Unable to access registries that require a login or anonymous token from behind a redirect.
Describe the change
A registry server that is just a redirect to a real server that requires auth will now work. Previously, auth was only sent to the first server (if and only if that server requested it), now it is only sent to the server that performed the auth. The auth package itself was also refactored a bit, removing unneeded interfaces and reducing exported fields.
How to verify it
Changelog text
Please verify and check that the pull request fulfills the following requirements