Refactor networking layer #803
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
Copying images has a delayed start and regclient throttles itself even on a local network.
Describe the change
This is a significant refactor of the networking stack to remove the default rate limit and reorder the copy of layers to speed up the start of the copy and prioritize the copy of large layers to reduce the typical time to copy an image.
reghttp
. This is being done directly by blob and manifest types.reghttp.Resp
interface. Replace it with a pointer to a struct with private values.time.Ticker
for rate limiting.time.Ticker
leaks goroutines. A simple time for the next request is good enough.reghttp.Resp
methods:next
method.pqueue.AcquireMulti
releases queues in reverse order to minimize risk of an acquire blocked by a soon to release queue.How to verify it
The copy command should start faster and copy large blobs earlier in the process to maximize concurrency:
Changelog text
Please verify and check that the pull request fulfills the following requirements