Tar paths should use forward slashes #788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon Mitchell <git@bmitch.net>
2b07568 to
6e93ed0
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
Fixes #786.
Describe the change
The correct path separator inside of a tar file is
/. On Windows, thefilepath.Cleanis converting these to backslashes. This either removes thefilepath.Cleanwhere it's not needed, or adds afilepath.ToSlashto ensure the tar filename separator is always assumed to be a/.How to verify it
Export an image on Windows.
Changelog text
/. (H/T @stormyyd)Please verify and check that the pull request fulfills the following requirements
Tests for this are difficult since they depend on Go's behavior on a Windows system.