Support pushing tagged manifests with different digest algorithms #778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These parameters are currently experimental and not standardized by OCI yet. Signed-off-by: Brandon Mitchell <git@bmitch.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
Describe the change
When pushing a tagged manifest, an extra parameter is needed to change the digest algorithm from the registry default. This is needed if the manifest digest needs to be fixed to a non-canonical value to avoid breaking referrers, signatures, and pinned references.
These parameters are currently experimental and not standardized by OCI yet. This change will be part of a proposal to OCI, and changing the digest algorithm of images should not be done in a production environment at this time.
How to verify it
Push content with a different digest to the latest development release of olareg.
Changelog text
Please verify and check that the pull request fulfills the following requirements