Remove rwfs internal package #772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was used for test implementations that were better handled with t.TempDir or olareg backed by memory. Signed-off-by: Brandon Mitchell <git@bmitch.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
Fixes #509.
Describe the change
Remove the internal
rwfspackage andWithFScalls that used it. This was used for test implementations that were better handled witht.TempDirorolaregbacked by memory.How to verify it
Internal code can be tested with
make test. External code should not have access to internal methods.Changelog text
Please verify and check that the pull request fulfills the following requirements