Skip to content

Conversation

thesayyn
Copy link
Contributor

@thesayyn thesayyn commented Jun 10, 2024

Fixes issue

bazel-contrib/rules_oci#588

Describe the change

Allows ~ tilde in reference paths such as ocidir://, this needed because Bazel adds tildes to namespace dependencies.

How to verify it

Added tests

Changelog text

Allow ~ tilde in reference paths

Please verify and check that the pull request fulfills the following requirements

  • Tests have been added or not applicable
  • Documentation has been added, updated, or not applicable
  • Changes have been rebased to main
  • Multiple commits to the same code have been squashed

Signed-off-by: thesayyn <thesayyn@gmail.com>
Copy link
Contributor

@sudo-bmitch sudo-bmitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. That's a curious choice on their part considering the ~ special meaning in the path for most Linux shells.

@sudo-bmitch sudo-bmitch merged commit 7bafb95 into regclient:main Jun 11, 2024
@thesayyn
Copy link
Contributor Author

thesayyn commented Jul 8, 2024

@sudo-bmitch do you happen to know when the next release of regctl is going to be?

@sudo-bmitch
Copy link
Contributor

@thesayyn I'd like to get that out within the next week or two. It's been too long. The blocker right now is getting some more sha512 support changes included and testing against a registry, and my free time is looking good to knock that out quickly.

@sudo-bmitch
Copy link
Contributor

@thesayyn release 0.7.0 is now out.

@thesayyn
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants