Set base font size on <html> #668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Odyseus
added a commit
to Odyseus/sphinx_rtd_theme_mod
that referenced
this pull request
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most elements have their font size set to
$base-font-size(14px), but some elements like lists and text in the sidebar inherit a font-size of 100% from<html>. This causes inconsistencies when viewed on a browser that sets a custom font size != 14px.This PR sets the font size of
<html>to$base-font-sizeso that everything has a uniform size, regardless of browser settings. It does not respect the browsers font size, which is bad for accessibility, but it does work with scaling by the browser.Fixes #125