Avoid printing dot when copyright holder already ends with dot #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would rather we remove the second added period and leave it up to the author how the copyright is punctuated. |
|
@Blendify thank you for the reply. Do you like this solution better? |
e.g. My Company, Inc.
|
Alright @Blendify, I've rebased the PR. |
|
Ok, looking for one more quick approval. |
|
I'd like it even better if the user could customize the entire copyright message (including copyright sign), but that is more the responsibility of Sphinx. LGTM |
emodric
added a commit
to netgen-layouts/layouts-docs
that referenced
this pull request
Oct 4, 2018
emodric
added a commit
to netgen-layouts/content-browser-docs
that referenced
this pull request
Oct 4, 2018
emodric
added a commit
to netgen/NetgenDocs
that referenced
this pull request
Oct 4, 2018
Odyseus
added a commit
to Odyseus/sphinx_rtd_theme_mod
that referenced
this pull request
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you set
copyright = "My Company, Inc."inconf.pyfor your documentation and generate html from it, the copyright is rendered like this:Which is bad, we ideally want to have only one dot at the end.
It can't be workarounded by setting
copyright = "My Company, Inc", because then man pages get rendered wrong, e.g.Therefore I am proposing this pull request. It is quite hard to fix it properly because it needs to be done per-theme and therefore it can bring some inconsistencies. If there is a better way to fix it, please let me know.