Skip to content

Conversation

violetagg
Copy link
Member

Before this change:

AbstractErrorWebExceptionHandler : [0861a0da-1]  500 Server Error for HTTP POST "/"

reactor.netty.http.server.RequestTimeoutException: null

After this change:

AbstractErrorWebExceptionHandler : [dbf4f5fb-1]  500 Server Error for HTTP POST "/"

reactor.netty.http.server.RequestTimeoutException: Request timed out
	Suppressed: reactor.core.publisher.FluxOnAssembly$OnAssemblyException:
Error has been observed at the following site(s):
	*__checkpoint ⇢ Handler com.example.MyController#hello(ServerHttpRequest) [DispatcherHandler]
	*__checkpoint ⇢ HTTP POST "/" [ExceptionHandlingWebHandler]
Original Stack Trace:

Before this change:

```
AbstractErrorWebExceptionHandler : [0861a0da-1]  500 Server Error for HTTP POST "/"

reactor.netty.http.server.RequestTimeoutException: null
```

After this change:

```
AbstractErrorWebExceptionHandler : [dbf4f5fb-1]  500 Server Error for HTTP POST "/"

reactor.netty.http.server.RequestTimeoutException: Request timed out
	Suppressed: reactor.core.publisher.FluxOnAssembly$OnAssemblyException:
Error has been observed at the following site(s):
	*__checkpoint ⇢ Handler com.example.MyController#hello(ServerHttpRequest) [DispatcherHandler]
	*__checkpoint ⇢ HTTP POST "/" [ExceptionHandlingWebHandler]
Original Stack Trace:
```
@violetagg violetagg added the type/enhancement A general enhancement label Dec 2, 2024
@violetagg violetagg added this to the 1.2.1 milestone Dec 2, 2024
@violetagg violetagg requested a review from chemicL December 2, 2024 12:13
@chemicL
Copy link
Member

chemicL commented Dec 2, 2024

Thanks @violetagg ! Combined with reactor/reactor-core#3901 this should improve the user experience at not much additional cost.

@violetagg
Copy link
Member Author

@chemicL Thanks for the review!

@violetagg violetagg merged commit 864474a into main Dec 2, 2024
14 checks passed
@violetagg violetagg deleted the remove-static-exception branch December 2, 2024 13:23
violetagg added a commit that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants