Interrupt VirtualThread task only from another Thread #3979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `BoundedElasticScheduler` processes a task, the task can be disposed. In the regular case the Thread executing the task will only be interrupted when the disposing Thread is different. With the Virtual Thread-based implementation this behaviour should be similar. Since it was not, this change aligns the new implementation to be similar in that regard. Fixes #3948 Signed-off-by: Dariusz Jędrzejczyk <dariusz.jedrzejczyk@broadcom.com>
chemicL
added a commit
that referenced
this pull request
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
BoundedElasticSchedulerprocesses a task, the task can be disposed. In the regular case the Thread executing the task will only be interrupted when the disposing Thread is different.With the Virtual Thread-based implementation this behaviour should be similar. Since it was not, this change aligns the new implementation to be similar in that regard.
Fixes #3948