Refactor ripple adding multiple option
#691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #305
This PR brings a full refactoring of the
Ripplecomponent and a new behavior.They way it used to work was by restarting the wave if it existed but now you'll have the choice of creating multiple waves. A new option
multiplewas added to the factory function and also arippleMultipleproperty is available for decorated components. If this option istrue, instead of restarting the wave, a new wave will be expanded. If the option isfalseyou'll get the same behavior as default.Since the
multipleeffect is closer to the spec, it is enabled by default for all components using the ripple. Also, the ripple now supports alsoonTouchStartso it works perfectly in mobile. Also methods on the ripple has been documented for the future since they are not straightforward.