-
-
Notifications
You must be signed in to change notification settings - Fork 794
Add closing of the icon details modal with the ESC key #900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kamijin-fanta
merged 11 commits into
react-icons:master
from
gabrielogregorio:feat-accessibility-improvements-esc-menu
Aug 13, 2024
Merged
Add closing of the icon details modal with the ESC key #900
kamijin-fanta
merged 11 commits into
react-icons:master
from
gabrielogregorio:feat-accessibility-improvements-esc-menu
Aug 13, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for contributing! This is very user-friendly. |
auto-merge was automatically disabled
August 13, 2024 11:11
Head branch was pushed to by a user without write access
7855c2f
to
0216900
Compare
I fixed the most prettier formatting, it had been forgotten |
5382af8
to
97de7b8
Compare
97de7b8
to
2ad9c87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added the useKeyDown hook to improve interaction with the site using the keyboard, this specific pull request I am using this hook to close the icon details modal by pressing the ESC key.
The hook listens to the global window "keydown" event and triggers a callback function with a key pressed.
Example of closing the modal using the ESC key
simplescreenrecorder-2024-01-11_19.57.13.mp4
The hook synchronizes the ref with the most current value of the callback function, without interrupting the listener.
Benefits:
With this it will be possible to use the ESC keys to close the icon detail modal, I personally find it much more practical.
References:
And on other sites.
I'm open to suggestions