[React 19] Update IconType type to return React.ReactNode #1004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React 19 requires ReactNode type as component output to remove linting errors.
perryd01
added a commit
to simonyiszk/schdesign-web
that referenced
this pull request
Dec 22, 2024
perryd01
added a commit
to simonyiszk/schdesign-web
that referenced
this pull request
Dec 22, 2024
* patch react-icons github.com/react-icons/react-icons/pull/1004 * update everything except buggy eslint packages
|
@kamijin-fanta would it be possible to get this merged in and released? |
1 task
|
We need this merged ASAP. Why is it taking so long? |
nolanleung
approved these changes
Jan 17, 2025
|
Any idea when this will be released ? |
|
Is this being released soon? |
|
thanks! published in v5.5.0 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React 19 requires ReactNode type as component output to remove linting errors in Typescript, end results are the same.