Fix iOS Yellow box warning "requires main queue setup" since it overrides constantsToExport but doesn't implement requiresMainQueueSetup #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
react-native-share#330 Add: ```` + (BOOL)requiresMainQueueSetup { return YES; } ````
…res-main-queue-setup Silence Yellow box warning "requires main queue setup"
|
@esutton, great! |
|
@jgcmarins Conflicts resolved. Thank you for your work! |
This was referenced Aug 4, 2018
dthian
pushed a commit
to viromedia/viro
that referenced
this pull request
Sep 25, 2019
…arnings This change mimics changes made in other RN modules like RCTImageLoader, react-native-share,etc react-native-share/react-native-share#331 facebook/react-native#17679 Starting this RN version, FB seems to default to NO main queue anyways, if not specified. But they raise these warnings anyway. Former-commit-id: 01a4cb4fed3760290f90d613e74ffa9a6b18c981
|
Thanks for the solution.It works |
ktemby
pushed a commit
to ktemby/viro
that referenced
this pull request
Oct 4, 2020
…arnings This change mimics changes made in other RN modules like RCTImageLoader, react-native-share,etc react-native-share/react-native-share#331 facebook/react-native#17679 Starting this RN version, FB seems to default to NO main queue anyways, if not specified. But they raise these warnings anyway. Former-commit-id: 01a4cb4fed3760290f90d613e74ffa9a6b18c981 Former-commit-id: 7f7b2f4 [formerly 81c55f2] Former-commit-id: 603678e10722369faebb9116903a9a96e809dfb6
ktemby
pushed a commit
to ktemby/viro
that referenced
this pull request
May 3, 2021
…arnings This change mimics changes made in other RN modules like RCTImageLoader, react-native-share,etc react-native-share/react-native-share#331 facebook/react-native#17679 Starting this RN version, FB seems to default to NO main queue anyways, if not specified. But they raise these warnings anyway. Former-commit-id: 01a4cb4fed3760290f90d613e74ffa9a6b18c981 Former-commit-id: 81c55f2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am seeing a lot of packages with these annoying Yellow Box warnings.
Easy low risk fix. Add method to confirm react-native-share is using main queue.